Update table tsconfig to use new compiler flags #471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yx-wu
requested review from
cmslewis and
giladgray
and removed request for
giladgray
|
Instead of adding the same options in multiple places, can you use tsconfig.json inheritance with the We ought to have a |
michael-yx-wu
force-pushed
the
mw/table-tsconfig
branch
from
b7a674a to
591afd7
Compare
|
Looks like that's only available for Typescript |
|
@michael-yx-wu yeah, that's fine; but I imagine bumping to 2.1 in this PR could be pretty simple too |
|
Okay, I'll give that a shot!
… On Jan 12, 2017, at 5:54 PM, Adi Dahiya ***@***.***> wrote:
@michael-yx-wu yeah, that's fine; but I imagine bumping to 2.1 in this PR could be pretty simple too
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
per ivogabe/gulp-typescript#459, this is not the correct approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use consistent compiler options across packages. Somewhat related: it also seems like
tslint:latesthas disabled the rules for these new flags to avoid being redundant.