Skip to content

[chore] Refactor Dialog to a functional component #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ggdouglas
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

@svc-palantir-github
Copy link

Refactor Dialog to be a functional component

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Fix up type in Dialog tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch from 18b3bd9 to 8506fdb Compare April 15, 2025 18:24
@ggdouglas ggdouglas force-pushed the gdouglas/refactor-dialog-fc branch from 8506fdb to ed76cea Compare April 15, 2025 18:34
@svc-palantir-github
Copy link

Refactor dialog tests to use RTL

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants