Fix some code quality and bug-risk issues #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/python-language-server, @pnijhara! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
pnijhara
force-pushed
the
pnijhara-patch-1
branch
from
12b95c8 to
f84fd85
Compare
ccordoba12
reviewed
Jun 9, 2020
|
@ccordoba12 Please review it again! |
|
Tests are failing for Python 2 with one of your changes. So if you want to see this merged now, you'd need to fix that. Otherwise, you could a wait a month or so, until we release a Python 3 version only. |
|
Ok, then I will revert the changes which are failing tests. Will send another PR for that when you release Python 3 version (only) |
ccordoba12
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pyls/workspace.pypyls/plugins/jedi_completion.pyreadfp()(Reverted 3rd change and will send another patch with python 3 (only) release)
Also added a
.deepsource.tomlconfiguration file to run continuous static analysis on the repository with DeepSource.Find other issues found here - https://deepsource.io/gh/pnijhara/python-language-server/issues/?category=recommended
Upon enabling DeepSource, quality and security analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.
DeepSource is free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others, and open-source projects like ThoughtWorks/Gauge, Masonite Framework, etc.
To enable DeepSource analysis after merging this PR, please follow these steps:
You can also look at the docs for more details. Do let me know if I can be of any help!