Skip to content

Do not start shutdown sequence on TCP when not checking parent process #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Do not start shutdown sequence on TCP when not checking parent process #820

merged 1 commit into from
Jun 22, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Jun 19, 2020

@ccordoba12 ccordoba12 added this to the 0.33.3 milestone Jun 19, 2020
ccordoba12
ccordoba12 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @andfoy!

@ccordoba12 ccordoba12 merged commit c57bf89 into palantir:develop Jun 22, 2020
@ccordoba12 ccordoba12 changed the title PR: Do not start shutdown sequence on TCP when not checking parent process Do not start shutdown sequence on TCP when not checking parent process Jun 22, 2020
@andfoy andfoy deleted the prevent_shutdown_on_tcp branch June 29, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.33.3
Development

Successfully merging this pull request may close these issues.

Connecting to external PyLS server is broken
2 participants
@andfoy @ccordoba12