Skip to content

Pass document path to jedi_names when a file is not placed in a module #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2020
Merged

Pass document path to jedi_names when a file is not placed in a module #882

merged 2 commits into from
Nov 4, 2020

Conversation

ccordoba12
Copy link
Contributor

@ccordoba12 ccordoba12 commented Nov 1, 2020 •
edited
Loading

Note: I added a test for this on the Spyder side (see spyder-ide/spyder#14119).

@ccordoba12
Pass document path to jedi_names when a file is not placed in a module
7edf85b 
That allows to get all symbols for those files instead of a subset of
them.
@ccordoba12 ccordoba12 added this to the 0.36.0 milestone Nov 1, 2020
@ccordoba12 ccordoba12 mentioned this pull request Nov 1, 2020
Merged
@ccordoba12 ccordoba12 modified the milestones: 0.36.0, 0.36.1 Nov 3, 2020
@ccordoba12
Use normpath when deciding to use the document's path in Jedi
4bde52e 
That allows completions and symbols to work on directories with spaces
@ccordoba12 ccordoba12 merged commit cf59b8f into palantir:develop Nov 4, 2020
@ccordoba12 ccordoba12 deleted the symbols-no-init branch November 4, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.36.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ccordoba12