chore(ramda): Remove dependency on external library #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*TLDR* Reduce final module size and dependency clutter. Ramda is cool. Using it can help make code more functional and expressive. However, it’s not always a good idea to couple a library to a third party dependency if we can solve the problem with a few lines of code. I guess this wouldn't be so much of an issue if the build output something which did not contain the `require` for the ES module. The main issue with requiring this third party dependency is that it increases the amount of code that needs to be downloaded, since we have another library which is required from this one. This is mainly a problem for those of us who are using native ES modules rather than using bundlers with tree shaking I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR Reduce final module size and dependency clutter.
Ramda is cool. Using it can help make code more functional and
expressive. However, it’s not always a good idea to couple a library
to a third-party dependency if we can solve the problem with a few
lines of code.
I guess this wouldn't be so much of an issue if the build output
something which did not contain the
requirefor the ES module.The main issue with requiring this third-party dependency is that
it increases the amount of code that needs to be downloaded, since
we have another library which is required from this one. This is
mainly a problem for those of us who are using native ES modules
rather than using bundlers with tree shaking I suppose.