Fish autocomplete stopped working on 8.1.4

[peterdragun]

Fish autocomplete stopped working in 8.1.4. By using git bisect I was able to identify fist commit that caused the issue - bcd3faa

I believe the issue was caused by removing line endings with ';'. Adding them back resolves issue for me.

When executing the eval (env _FOO_BAR_COMPLETE=fish_source foo-bar) I get fish: Expected end of the statement, but found end of the input

Environment:

• Python version: 3.11.4
• Click version: 8.1.4, 8.1.5
• Fish version: 3.6.1

[davidism]

Happy to review a PR.

[davidism]

@exploide

[exploide]

Oh no. I'm sorry causing that one. The problem is it depends how the generated completion scripts gets loaded.

# does indeed not work without ;
$ eval (env _FOO_BAR_COMPLETE=fish_source foo-bar)

# works
$ eval "$(env _FOO_BAR_COMPLETE=fish_source foo-bar)"

# also works
$ _FOO_BAR_COMPLETE=fish_source foo-bar | source

If you look in the fish repo, the source variant seems to be preferred. And the "$(...)" variant preserves newlines. Unfortunately the only non-working variant seems to be the documented one here. So it's of course fine if you add the ; back, though they are not idiomatic for fish.

[davidism]

If all three work with semicolon, then it's probably best to use that as well as update the docs to use the most idiomatic approach.

[peterdragun]

I have updated my PR to also include the update for docs to follow the fish repo recommendation.