Skip to content

Permission to generate stubs for Flask in typeshed #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rowillia opened this issue Sep 7, 2016 · 6 comments
Closed

Permission to generate stubs for Flask in typeshed #2012

rowillia opened this issue Sep 7, 2016 · 6 comments

Comments

@rowillia
Copy link

rowillia commented Sep 7, 2016 •
edited by untitaker
Loading

Howdy,

I'd like to add stubs for Flask to https://github.com/python/typeshed, a repository used to store PEP 484 type signatures for the python stdlib and popular third party libraries. As per PEP 484, permission is required from the library owner before merging type signatures into typeshed - https://www.python.org/dev/peps/pep-0484/#the-typeshed-repo

Here's the corresponding typeshed issue -
python/typeshed#28
@untitaker
Copy link
Contributor

I think it's fine. @davidism @ThiefMaster?

@untitaker
Copy link
Contributor

Also while we're at it, if we give you permission for Flask, this permission also holds for Jinja and Werkzeug.

@ThiefMaster
Copy link
Member

👍 seems like a good idea

@rowillia
Copy link
Author

rowillia commented Sep 7, 2016

Sweet! Thanks @ThiefMaster and @untitaker!

@davidism
Copy link
Member

davidism commented Sep 7, 2016

Sure, would be interested to see what's produced.

This was referenced Sep 7, 2016
Closed
Closed
@rowillia
Copy link
Author

@davidism @untitaker @ThiefMaster mind taking a look at pallets/itsdangerous#69? I link to the typestubs there as well as some interesting (I think) bugs found by adding types.

rowillia pushed a commit to rowillia/typeshed that referenced this issue Nov 29, 2016
Add stubs for jinja2
3ae9231 
I added strong types to the class that users are likely to interact with and left
the rest untyped for now.  This is needed to support Flask.

Permission is given here - pallets/flask#2012
@rowillia rowillia mentioned this issue Nov 29, 2016
Merged
JukkaL pushed a commit to python/typeshed that referenced this issue Dec 1, 2016
@rowillia @JukkaL
Add stubs for jinja2 (#722)
5d61aa5 
I added strong types to the class that users are likely to interact with and left
the rest untyped for now.  This is needed to support Flask.

Permission is given here - pallets/flask#2012
@pcorpet pcorpet mentioned this issue Jan 14, 2019
Merged
ilevkivskyi pushed a commit to python/typeshed that referenced this issue Jan 30, 2019
@pcorpet @ilevkivskyi
Create stubs for Flask (#2740)
75581cf 
See permission in pallets/flask#2012.

Fixes #28.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThiefMaster @rowillia @untitaker @davidism