Skip to content

Commit 285eb1e

Browse files
NikhilKumarMjreback
authored andcommitted
Updated condition to skip for pytables build issue on numpy 1.15 #22098 (#22522)
1 parent 5f89597 commit 285eb1e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

pandas/compat/numpy/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
_np_version_under1p14 = _nlv < LooseVersion('1.14')
1717
_np_version_under1p15 = _nlv < LooseVersion('1.15')
1818

19+
1920
if _nlv < '1.9':
2021
raise ImportError('this version of pandas is incompatible with '
2122
'numpy < 1.9.0\n'

pandas/tests/io/test_pytables.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from pandas import (Series, DataFrame, Panel, MultiIndex, Int64Index,
1515
RangeIndex, Categorical, bdate_range,
1616
date_range, timedelta_range, Index, DatetimeIndex,
17-
isna, compat, concat, Timestamp, _np_version_under1p15)
17+
isna, compat, concat, Timestamp)
1818

1919
import pandas.util.testing as tm
2020
import pandas.util._test_decorators as td
@@ -2192,9 +2192,9 @@ def test_unimplemented_dtypes_table_columns(self):
21922192
pytest.raises(TypeError, store.append, 'df_unimplemented', df)
21932193

21942194
@pytest.mark.skipif(
2195-
not _np_version_under1p15,
2196-
reason=("pytables conda build package needs build "
2197-
"with numpy 1.15: gh-22098"))
2195+
LooseVersion(np.__version__) == LooseVersion('1.15.0'),
2196+
reason=("Skipping pytables test when numpy version is "
2197+
"exactly equal to 1.15.0: gh-22098"))
21982198
def test_calendar_roundtrip_issue(self):
21992199

22002200
# 8591

0 commit comments

Comments
 (0)