Skip to content

TST: remove skip for pytables build issue on numpy 1.15 #22098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jul 28, 2018 · 3 comments · Fixed by #22522
Closed

TST: remove skip for pytables build issue on numpy 1.15 #22098

jreback opened this issue Jul 28, 2018 · 3 comments · Fixed by #22522
Labels
Build Library building on various platforms good first issue Testing pandas testing functions or related to the test suite
Milestone
0.24.0

Comments

@jreback
Copy link
Contributor

jreback commented Jul 28, 2018

No description provided.

@jreback jreback added Testing pandas testing functions or related to the test suite Build Library building on various platforms labels Jul 28, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 28, 2018
@jreback jreback mentioned this issue Jul 28, 2018
Merged
@TomAugspurger TomAugspurger mentioned this issue Aug 3, 2018
Closed
@TomAugspurger
Copy link
Contributor

The root cause is that numpy/numpy#11656

import pickle
import numpy as np
pickle.dumps(np.datetime64('2016-01-01T00:00:00.000000000'))

that just surfaced in the pytables test, since it needs to serialize the datetime64.

@TomAugspurger
Copy link
Contributor

NumPy 1.15.1 is out, and should include this fix.

Updating

pandas/pandas/tests/io/test_pytables.py

Lines 2194 to 2197 in 68273a7

@pytest.mark.skipif(
not _np_version_under1p15,
reason=("pytables conda build package needs build "
"with numpy 1.15: gh-22098"))
to skip if and only if the NumPy version is exactly 1.15.0 will make for a good first contribution.

@NikhilKumarM NikhilKumarM mentioned this issue Aug 27, 2018
Merged
2 tasks
@NikhilKumarM
Copy link
Contributor

@TomAugspurger Could you please let me know if I have to make any changes. Thanks!!

jreback pushed a commit that referenced this issue Aug 31, 2018
@NikhilKumarM @jreback
Updated condition to skip for pytables build issue on numpy 1.15 #22098…
285eb1e 
… (#22522)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this issue Oct 1, 2018
@NikhilKumarM
Updated condition to skip for pytables build issue on numpy 1.15 pand…
e22de52 
…as-dev#22098 (pandas-dev#22522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
3 participants
@jreback @TomAugspurger @NikhilKumarM