Skip to content

Typing error in "ExcelFile class" example #15037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ennemosc opened this issue Jan 2, 2017 · 2 comments · Fixed by #15040
Closed

Typing error in "ExcelFile class" example #15037

ennemosc opened this issue Jan 2, 2017 · 2 comments · Fixed by #15040
Labels
Milestone

Comments

@ennemosc
Copy link
Contributor

ennemosc commented Jan 2, 2017

Current example ExcelFile class (see ExcelFile class pandas 0.19.2 documentation) :

xlsx = pd.ExcelFile('path_to_file.xls)
df = pd.read_excel(xlsx, 'Sheet1')

Problem description

The closing apostrophe is missing for 'path_to_file.xls'

Expected Output

xlsx = pd.ExcelFile('path_to_file.xls')
df = pd.read_excel(xlsx, 'Sheet1')

Output of pd.show_versions()

INSTALLED VERSIONS ------------------ commit: None python: 3.5.2.final.0 python-bits: 64 OS: Windows OS-release: 10 machine: AMD64 processor: Intel64 Family 6 Model 94 Stepping 3, GenuineIntel byteorder: little LC_ALL: None LANG: en

pandas: 0.18.1
nose: 1.3.7
pip: 9.0.1
setuptools: 27.2.0
Cython: 0.24.1
numpy: 1.11.3
scipy: 0.18.1
statsmodels: None
xarray: None
IPython: 5.1.0
sphinx: 1.5
patsy: 0.4.1
dateutil: 2.5.3
pytz: 2016.10
blosc: None
bottleneck: 1.1.0
tables: 3.2.2
numexpr: 2.6.1
matplotlib: 1.5.3
openpyxl: 2.3.2
xlrd: 1.0.0
xlwt: 1.1.2
xlsxwriter: 0.9.3
lxml: 3.6.4
bs4: 4.5.1
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: 1.0.13
pymysql: None
psycopg2: None
jinja2: 2.8
boto: 2.42.0
pandas_datareader: None

@jorisvandenbossche
Copy link
Member

There is indeed a ' missing. Want to do a PR to fix this?

@jorisvandenbossche jorisvandenbossche added this to the Next Major Release milestone Jan 2, 2017
@ennemosc
Copy link
Contributor Author

ennemosc commented Jan 2, 2017

Would be my first PR, I'm perfectly fine with contributing to the pandas community :-)

@jreback jreback modified the milestones: 0.20.0, Next Major Release Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants