Skip to content

BLD: parsers.pyx seems to be re-running on each commit #22831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Sep 25, 2018 · 2 comments
Closed

BLD: parsers.pyx seems to be re-running on each commit #22831

jreback opened this issue Sep 25, 2018 · 2 comments
Labels
Build Library building on various platforms
Milestone
0.24.0

Comments

@jreback
Copy link
Contributor

jreback commented Sep 25, 2018

for some reason parsers.pyx (and the generated parsers.c) seems to be rebuilding on each commit (whether anything changed or not).

cc @gfyoung @jbrockmendel

maybe something odd in setup.py
@jreback jreback added the Build Library building on various platforms label Sep 25, 2018
@jreback jreback added this to the 0.24.0 milestone Sep 25, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 29, 2018

Weird...even rebuilds parsers.pyx when I install on the same commit several times...

gfyoung added a commit to forking-repos/pandas that referenced this issue Sep 29, 2018
@gfyoung
BLD: Drop nonexistent dependency of _libs/parsers
9414b17 
Follow-up to pandas-devgh-22469.
Closes pandas-devgh-22831.
@gfyoung
Copy link
Member

gfyoung commented Sep 29, 2018 •
edited
Loading

maybe something odd in setup.py

Indeed, it is. git bisect indicates that #22469 forgot to drop numpy_helper.h from the dependencies list of _libs/parsers, as the file became non-existent.

@gfyoung gfyoung mentioned this issue Sep 29, 2018
Merged
jbrockmendel pushed a commit that referenced this issue Sep 29, 2018
@gfyoung @jbrockmendel
BLD: Drop nonexistent dependency of _libs/parsers (#22883)
f771ef6 
Follow-up to gh-22469.
Closes gh-22831.
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this issue Oct 1, 2018
@gfyoung
BLD: Drop nonexistent dependency of _libs/parsers (pandas-dev#22883)
3abad35 
Follow-up to pandas-devgh-22469.
Closes pandas-devgh-22831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
2 participants
@jreback @gfyoung