Skip to content

Use Substitution Decorator for CustomBusinessMonthEnd #25828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Mar 22, 2019 · 1 comment · Fixed by #25868
Closed

Use Substitution Decorator for CustomBusinessMonthEnd #25828

WillAyd opened this issue Mar 22, 2019 · 1 comment · Fixed by #25868
Labels
Docs good first issue
Milestone
0.25.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 22, 2019

This is a follow up to https://github.com/pandas-dev/pandas/pull/21093/files#r188805397 which wasn't working with Py27. Now that that is a thing of the past we should be able to use the more idiomatic Substitution approach to generating this docstring
@WillAyd WillAyd added this to the Contributions Welcome milestone Mar 22, 2019
@Batalex
Copy link
Contributor

Batalex commented Mar 22, 2019

Hi,
I would like to give it a try as a first contribution.
It does not seem to be very complex when looking at the contributing guide

Batalex pushed a commit to Batalex/pandas that referenced this issue Mar 25, 2019
DOC: use substitution decorator for business month classes (pandas-de…
dd4e758 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
61b96f5 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
0dd7986 
…v#25828)
@Batalex Batalex mentioned this issue Mar 25, 2019
Merged
4 tasks
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
f5cc28d 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
72776ec 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
be8c313 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 25, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
d5c50d3 
…v#25828)
Batalex added a commit to Batalex/pandas that referenced this issue Mar 26, 2019
@Batalex
DOC: use substitution decorator for business month classes (pandas-de…
f6959d3 
…v#25828)
WillAyd pushed a commit that referenced this issue Mar 26, 2019
@Batalex @WillAyd
DOC: use substitution decorator for business month classes (#25828) (#…
d404460 
…25868)
@gfyoung gfyoung modified the milestones: Contributions Welcome, 0.25.0 Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs good first issue
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

DOC: use substitution decorator for business month classes (#25828) Batalex/pandas
3 participants
@WillAyd @gfyoung @Batalex