Skip to content

COMPAT: numpy test warning #30334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nschloe opened this issue Dec 18, 2019 · 4 comments · Fixed by #30345
Closed

COMPAT: numpy test warning #30334

nschloe opened this issue Dec 18, 2019 · 4 comments · Fixed by #30345
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@nschloe
Copy link
Contributor

nschloe commented Dec 18, 2019

I'm currently testing a numpy deprecation to assess its impact on the ecosystem (numpy/numpy#10615). To this end, I'd like to run pandas tests with -Werror. Doing that, I see that pandas throws a bunch of warnings at other places. Are those intentional? Perhaps pandas should test warning-free out of the box.

@TomAugspurger
Copy link
Contributor

We raise on warnings from NumPy in our numpydev build, which uses the environment from ci/deps/azure-37-numpydev.yaml.

I'm not sure how feasible it would be to fail on warnings for all our builds, given the number of optional dependencies we have.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Dec 18, 2019

@jbrockmendel
Copy link
Member

I'm not sure how feasible it would be to fail on warnings for all our builds, given the number of optional dependencies we have.

This would fail in a bunch of places we don't have control over. The biggest one is imports from collections that need to be updated to import from collections.abc. We could try silencing those in the pytest config and see if whats left is manageable.

@nschloe
Copy link
Contributor Author

nschloe commented Dec 18, 2019

I'm playing around with it atm and will submit a PR shortly. We can look at the diff then.

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Dec 19, 2019
@jreback jreback added this to the 1.0 milestone Dec 20, 2019
@jreback jreback modified the milestones: 1.0, Contributions Welcome Jan 6, 2020
@jreback jreback changed the title tests have warnings COMPAT: numpy test warning Jan 20, 2020
@jreback jreback modified the milestones: Contributions Welcome, 1.1 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants