-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
COMPAT: numpy test warnings #30345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: numpy test warnings #30345
Conversation
The truediv ones look perfect, thanks |
needs |
@nschloe if you make a PR for just the truediv part id be comfortable merging that |
The truediv part alone won't help me much, but feel free to just take the code and include it. I'd rather keep working on this one here until it's in shape. |
can you merge master; we merged a patch which partially overlaps with this |
@jreback Done. |
@jbrockmendel if any comments |
can you rebase |
There are conflicts now. Perhaps merge then? |
Merged master. |
Hi @nschloe - sorry to chase you up, just wanted to ask whether you're still working on this :) |
Just pushed a tentative fix. |
LGTM |
Thanks @nschloe |
Fixes #30334.
Some of the warnings are coming from within pandas (like the FutureWarning on truediv), some are numpy warnings (like the nan-warning on sign). All in all changes are minor.
Tests are passing with
-Werror
for me now.