Skip to content

COMPAT: numpy test warnings #30345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 21, 2020
Merged

COMPAT: numpy test warnings #30345

merged 13 commits into from
Jan 21, 2020

Conversation

nschloe
Copy link
Contributor

@nschloe nschloe commented Dec 19, 2019

Fixes #30334.

Some of the warnings are coming from within pandas (like the FutureWarning on truediv), some are numpy warnings (like the nan-warning on sign). All in all changes are minor.

Tests are passing with -Werror for me now.

@pep8speaks
Copy link

pep8speaks commented Dec 19, 2019

Hello @nschloe! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-20 19:27:10 UTC

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Dec 19, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 19, 2019
@jbrockmendel
Copy link
Member

The truediv ones look perfect, thanks

@nschloe nschloe requested a review from jreback December 20, 2019 17:05
@jbrockmendel
Copy link
Member

needs black pandas/tests/plotting/test_datetimelike.py

@jbrockmendel
Copy link
Member

@nschloe if you make a PR for just the truediv part id be comfortable merging that

@nschloe
Copy link
Contributor Author

nschloe commented Dec 24, 2019

The truediv part alone won't help me much, but feel free to just take the code and include it. I'd rather keep working on this one here until it's in shape.

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Dec 25, 2019
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

can you merge master; we merged a patch which partially overlaps with this

@nschloe
Copy link
Contributor Author

nschloe commented Jan 1, 2020

@jreback Done.

@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

@jbrockmendel if any comments

@jreback jreback removed this from the 1.0 milestone Jan 6, 2020
@jreback
Copy link
Contributor

jreback commented Jan 6, 2020

can you rebase

@nschloe
Copy link
Contributor Author

nschloe commented Jan 6, 2020

can you rebase

There are conflicts now. Perhaps merge then?

@nschloe
Copy link
Contributor Author

nschloe commented Jan 6, 2020

Merged master.

@MarcoGorelli
Copy link
Member

Hi @nschloe - sorry to chase you up, just wanted to ask whether you're still working on this :)
Seems that there's some test failures, but I can't check them as it says "build not found"

@jreback jreback changed the title fix test warnings COMPAT: numpy test warnings Jan 20, 2020
@nschloe
Copy link
Contributor Author

nschloe commented Jan 20, 2020

Just pushed a tentative fix.

@jreback jreback added this to the 1.1 milestone Jan 20, 2020
@jreback
Copy link
Contributor

jreback commented Jan 20, 2020

cc @jbrockmendel

@jbrockmendel
Copy link
Member

LGTM

@WillAyd WillAyd merged commit e31c5ad into pandas-dev:master Jan 21, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 21, 2020

Thanks @nschloe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COMPAT: numpy test warning
8 participants