-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BLD/CI: 3.9 support #36296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We need to fix #34014. It won't compile right now. |
Also #36298 is needed to build with -Werror on 3.9 -- I haven't run the pandas test suite with it, but it did fix pandas enough that my pandas-using project was happy in with 3.9 in travisci |
Co-authored-by: Fangchen Li <[email protected]>
@jbrockmendel how comfortable are you with backporting #34997 and #35928? IMO those probably decide whether we're likely to add support for Pytyhon 3.9 in 1.1.x or 1.2.0. |
1.1.x still needs to support 3.6. so need to make sure any changes to don't break 3.6 support. |
I am not sure #34997 is a good one to backport, it involve quite some tricky code / corner cases? |
what do we actually need to support 3.9 in 1.1.3? the above PRs are nice to have for cython3 but don't appear to actually be needed correct? (exempting #36298) |
do we actually need cython3 to compile for 3.9? e.g. https://travis-ci.org/github/pandas-dev/pandas/jobs/726742374 |
See my 3 day old comment for a report of exactly what I needed to build with 3.9
Just 2 lines of change plus cython3. |
The reason why @jreback is asking is because there are two difficulties with bumping to cython3: 1) it isn't actually released yet and 2) bumping to it breaks a bunch of our tests, the fixes for which are not easy. So the question is if there is any option that doesnt require cy3. |
numpy is building with 29.21: https://github.com/numpy/numpy/releases/tag/v1.19.2 can try removing the -pre here: https://github.com/pandas-dev/pandas/blob/master/ci/build39.sh#L7 and see what happens |
I just tried this. We only need #36298 + remove --pre to make it work. And all tests passed on my machine (without optional dependencies). |
wow let's do it (single PR wouos be great as have to backport) also can i update .travis.yml to make this a build that is required (remove the allow failures for that one) |
cc @pandas-dev/pandas-core
The text was updated successfully, but these errors were encountered: