Skip to content

Representation of pd.Timestamp is not ISO8601 compliant. #36351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kotval opened this issue Sep 14, 2020 · 4 comments
Closed

Representation of pd.Timestamp is not ISO8601 compliant. #36351

kotval opened this issue Sep 14, 2020 · 4 comments
Labels
Datetime Datetime data dtype Usage Question

Comments

@kotval
Copy link

kotval commented Sep 14, 2020

ISO 8601 specifies that the date and time portion of a timestamp is separated by a "T", but python's datetime.isoformat allows any character to separate them. To comply with ISO8601, line 650 should be changed to include a "T" in between the date and the time. Since this also complies with datetime.isoformat, there is no reason not to change this.

@jreback
Copy link
Contributor

jreback commented Sep 14, 2020

you can use strftime if you actually want to do this but why would we change this and break the world?

@TomAugspurger
Copy link
Contributor

Agreed that we can't just change this.

@jreback
Copy link
Contributor

jreback commented Sep 14, 2020

and we use the isoformat from datetime already (which has a default sep argument of T)

@jreback jreback added this to the No action milestone Sep 14, 2020
@jreback jreback added Usage Question Datetime Datetime data dtype labels Sep 14, 2020
@jreback jreback closed this as completed Sep 14, 2020
@jreback
Copy link
Contributor

jreback commented Sep 14, 2020

@kotval the code you are referencing is simply a repr and not thr isoformat function - so this is no where implied even that this is ISO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Usage Question
Projects
None yet
Development

No branches or pull requests

3 participants