Skip to content

CI: Deduplicate linting checks #36642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsaxton opened this issue Sep 25, 2020 · 2 comments · Fixed by #36716
Closed

CI: Deduplicate linting checks #36642

dsaxton opened this issue Sep 25, 2020 · 2 comments · Fixed by #36716
Labels
CI Continuous Integration
Milestone

Comments

@dsaxton
Copy link
Member

dsaxton commented Sep 25, 2020

#36471 added some linting checks (e.g., black, flake8) to a pre-commit workflow which are duplicated in https://github.com/pandas-dev/pandas/blob/master/ci/code_checks.sh. Once we feel good that the pre-commit checks are right we should go ahead and delete them from code_checks.sh.

cc @MarcoGorelli

@dsaxton dsaxton added the CI Continuous Integration label Sep 25, 2020
@rhshadrach
Copy link
Member

I often like to run some of these checks via code_checks.sh even before committing, typically black, isort, and flake8. The first two aren't an issue for me since they don't require command line options. However flake8 requires a lot, is there an easy way to manually run flake8 without doing it via code_checks?

@rhshadrach
Copy link
Member

I should have googled first... pre-commit run --all-files works great.

fangchenli added a commit to fangchenli/pandas that referenced this issue Sep 28, 2020
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants