-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
add travis doc build #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Check out jtratner/pandas@2c285ea . I think that covers what you're looking for. It really depends how long the job takes - https://travis-ci.org/jtratner/pandas/jobs/7895295 |
looks ok, but i'm thinking about the possible numpy dependency issue here. there's a few examples in the docs that throw an error for slightly older versions of numpy...i wouldn't want this to always fail because of that. i was actually thinking only a doc build and no other tests so another row in the build matrix... |
@cpcloud I updated it a bit - jtratner/pandas@bcae377 . It does mean that the test now has to wait for one of the other tests to finish (since it looks like Travis will only run 5 tests concurrently), which means it adds about 20 minutes to testing time. Would it make more sense to incorporate with one of the other version tests? |
An extra 20 minutes is unacceptable IMHO. Travis is already slow enough. Probably better to put it in one of the 2.7 like u had. Just need to make sure that no exceptions are generated (which is the point really...) but need to see if there are any benign exceptions generated by numpy... I get these when I run the doc build and I believe it's because I use dev numpy. |
i'm going to test a doc build on |
can we shove this in the 2.7 non-us build? |
probably would be ok, i just want to check those deps first... |
So, my branch wasn't actually testing doc building, because it didn't have |
@jreback can assume that the doc-building machine has |
yep has all deps AFAIN |
Okay, this doesn't work right now, because make docs is set to be silent. Also, it looks like sphinx doesn't get installed, so I'll have to fix again. |
also there are some doc build issues that i'm fixing right now...for some reason when branch depending on numpy versions in |
Looks like it needs IPython too ... check out the failing build: https://travis-ci.org/jtratner/pandas/jobs/7913726 (at least we now know that it errors out here) |
yep just add a |
if u do that you might want to add ipython to |
@cpcloud yeah, added that and also added sphinx to versions too |
@cpcloud now it finds a weird unicode issue - do you get this too? https://travis-ci.org/jtratner/pandas/jobs/7915482 |
might be because of the locale...see if u can repro it on ur machine...i'll try in a vagrant box |
actually before we do that can u try running it in the non zh_CN locale version |
yeah, though I have 2 builds pending so it might take a while. On Sat, Jun 8, 2013 at 10:12 PM, Phillip Cloud [email protected]:
|
@jtratner any luck/progress/decisions to abandon this? i would happily close if this is going to waste time |
@cpcloud I have to look back, but I think it was just fixing the |
yes everything on travis is completely dwarfed by build time although u can put |
That's interesting.... Does it try to cache between commits?
|
@cpcloud building docs works now, it adds very little time to the overall build time, plus this build shows that it actually fails on errors :P https://travis-ci.org/jtratner/pandas/builds/8261960 [turns out there was a |
probably not necessary to build on python 3 and python 2 unless the docs are built on that. @changhiskhan what python version are you running on the doc-building box? |
@cpcloud yeah, that's not what I'd put in the merge to pandas if we included at all...I mostly wanted to see if it would fail (which, of course, it did :P) |
btw makefile stuff is nice 👍 |
It probably should be added to a full build, else it will skip things that
|
It is actually not fully clear to me what docs are exactly built:
|
Docs are built only on the 2.7 build for all travis runs, but the upload ONLY happens on master (which makes sense), otherwise it fails (but the doc log is always their). The api docs are NOT built as they take a lot of time. The build is actually in the background while network tests are running. @y-p did a nice job on this! A py3 doc build could be done (just add it in travis). You could modify |
Thanks for the clarification! |
I was thinking, would it be an option to have a seperate travis build for only the docs (and then maybe the api can be included), as a build that is not included in the fast-finish matrix so it is not delaying the tests? |
its not that hard to add another build (as we have an optional part of the matrix, e.g. the numpy 1.9 build is their). you could certainly build the docs, then write the log file, then parse the log file and fail it appropriately, e.g. say you fail on certain types of warnings. ok..let's reopen if you want me to add a build I can easily, then you could tweak the build script and test for it. |
Hmm, in principle we could search for something like
in the doc logs and let travis fail. Something else, Read The Docs also provides automatic updating of your docs for every commit to master (and also some other maybe interesting features: http://read-the-docs.readthedocs.org/en/latest/features.html). |
read the docs doesn't build extensions - so won't work for us iirc |
@jreback ah yes, indeed, that is the case Something like this jorisvandenbossche@b086afd would let travis fail if there is an exception in the code examples of the doc build (with the doc build in travis build 3 as is the case now, so without adding an extra build. That could be a start). Result of travis you can see here: https://travis-ci.org/jorisvandenbossche/pandas/jobs/22765601 (the third failed because of the docs). |
Something else, the scipy version in the 2.7 build (where the docs are built) is too old (scipy 0.10) for the docs (you get an exception in the interpolation section, |
building a wheel for scipy 0.13.3 now for the 2.7 build. this is all done in the i'll post when its done. |
how much extra time do you figure build the full docs is to versus the with |
Well, I think a full doc build is about 10 mins, while --no-api is something like 2-3 minutes (rough estimates). So a lot longer as the test suite I think? (as most time on travis is spent installing all packages?) But maybe this are two not necessarily intertwined issues:
|
Ok, maybe easiest way to proceed is to add a validation step in just put it at the end of the fyi....scipy is now updated and docs building correctly http://pandas-docs.github.io/pandas-docs-travis/missing_data.html#interpolation |
@jreback Thanks! Well, I first put it in |
you may have to wrap that in something like
to only do this on the doc builds..... |
you can test for a nonempty string with [ -n "$DOC_BUILD" ] |
@jorisvandenbossche - that looks like a nice and simple way to check |
not sure if this is worth the trouble but it may catch version incompatibility issues and other bugs not caught by the test suite.
The text was updated successfully, but these errors were encountered: