Skip to content

TST: Add tests for observance rules in holiday.py #38139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
leonarduschen opened this issue Nov 28, 2020 · 3 comments
Closed
3 tasks done

TST: Add tests for observance rules in holiday.py #38139

leonarduschen opened this issue Nov 28, 2020 · 3 comments
Assignees
@ivanovmg
Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite

Comments

@leonarduschen
Copy link
Contributor

leonarduschen commented Nov 28, 2020 •
edited
Loading

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.

None of the observance rules (e.g. next_workday, before_nearest_workday) are tested
@leonarduschen leonarduschen added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 28, 2020
@ivanovmg
Copy link
Member

ivanovmg commented Dec 1, 2020

take

@ivanovmg ivanovmg self-assigned this Dec 1, 2020
@ivanovmg ivanovmg mentioned this issue Dec 1, 2020
Merged
5 tasks
@ivanovmg
Copy link
Member

ivanovmg commented Dec 1, 2020 •
edited
Loading

I guess that there are tests for those in pandas/tests/tseries/holiday/test_observance.py.
I added several cases for next_workday and before_nearest_workday (I guess all possible cases) in the PR #38215, but there are other observance rules, which can be covered with more cases as well.

@jreback jreback added Testing pandas testing functions or related to the test suite Frequency DateOffsets and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 2, 2020
@mroeschke
Copy link
Member

Looks like pandas/tests/tseries/holiday/test_observance.py has been pretty fleshed out in the meantime to meet the spirit of the original issue so closing. Can open a new issue with specific items if there are followups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanovmg ivanovmg

Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @mroeschke @ivanovmg @leonarduschen