Skip to content

TST: add cases for nearest_workday and before_nearest_workday #38215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

ivanovmg
Copy link
Member

@ivanovmg ivanovmg commented Dec 1, 2020

Add cases for testing observance rules nearest_workday and before_nearest_workday for their full coverage.

@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback jreback added Frequency DateOffsets Testing pandas testing functions or related to the test suite labels Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

can you merge master, CI looks to be acting up.

@ivanovmg ivanovmg requested a review from jreback December 2, 2020 07:46
@ivanovmg
Copy link
Member Author

ivanovmg commented Dec 2, 2020

Linux tests are red due to a failure to build environment (new pip).
Windows test failure is irrelevant.

    @tm.network
    @pytest.mark.single
    def test_round_trip_exception_(self):
        # GH 3867
        csv = "https://raw.github.com/hayd/lahman2012/master/csvs/Teams.csv"
>       df = pd.read_csv(csv)

@simonjayhawkins
Copy link
Member

Linux tests are red due to a failure to build environment (new pip).
Windows test failure is irrelevant.

re-run and green

@jreback jreback merged commit 7757844 into pandas-dev:master Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

thanks @ivanovmg

@ivanovmg ivanovmg deleted the bug_38139 branch December 2, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants