Skip to content

DOC: Remove unsupported parameters in Resampler.mean #48803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
donghyyun opened this issue Sep 27, 2022 · 6 comments · Fixed by #48980
Closed
1 task done

DOC: Remove unsupported parameters in Resampler.mean #48803

donghyyun opened this issue Sep 27, 2022 · 6 comments · Fixed by #48980
Assignees
@donghyyun
Labels
Docs Resample resample method

Comments

@donghyyun
Copy link
Contributor

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/reference/api/pandas.core.resample.Resampler.mean.html

Documentation problem

According to the comment, numba engine hasn't be implemented for resample.

However, the reference document says that they are supporting the numba engine.

Suggested fix for documentation

Please remove 'engine', 'engine_kwargs' in parameters section.
@donghyyun donghyyun added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 27, 2022
@mhaoda
Copy link

mhaoda commented Sep 27, 2022

Hi, can I work on this issue ?

@Pro-Coder04
Copy link

take

@phofl phofl added Resample resample method and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 27, 2022
@phofl
Copy link
Member

phofl commented Sep 27, 2022

Feel free, contributions welcome

@mhaoda
Copy link

mhaoda commented Sep 28, 2022

Feel free, contributions welcome

sure, then can you assign it to me?

@donghyyun
Copy link
Contributor Author

donghyyun commented Sep 28, 2022 •
edited
Loading

@mhaoda
I just wanted to confirm with the pandas member that the documentation is indeed wrong.
I will take this issue.

@rhshadrach rhshadrach added this to the Contributions Welcome milestone Sep 28, 2022
@donghyyun
Copy link
Contributor Author

take

This was referenced Oct 1, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donghyyun donghyyun

Labels
Docs Resample resample method
Projects
None yet
Milestone
No milestone
5 participants
@donghyyun @rhshadrach @mhaoda @phofl @Pro-Coder04