Skip to content

DOC: Added mean function as a method of Resampler and updated docstring #48902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

donghyyun
Copy link
Contributor

@donghyyun donghyyun commented Oct 1, 2022

By default, the Resampler.mean docstring is inherited from GroupBy.mean. As a result, unsupported parameters 'engine' and 'engine_kwargs' were created in the API documentation.

To do this, I defined the Mean function as a method of Resampler and wrote the docstring of the function itself.

FYI: I think it is unnecessary to add this issue to the Whatsnew section, so I left it.

@mroeschke mroeschke assigned mroeschke and unassigned mroeschke Oct 3, 2022
@mroeschke mroeschke added Docs Resample resample method labels Oct 3, 2022
@donghyyun
Copy link
Contributor Author

@mroeschke
Is there anything I missed or need to revise?

@donghyyun donghyyun changed the title DOC: Added mean function as method of Resampler and updated docstring DOC: Added mean function as a method of Resampler and updated docstring Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Resample resample method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Remove unsupported parameters in Resampler.mean
2 participants