-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Parameter Name of startingMonth for QuarterEnd is Misleading #5307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think this is worth changing - should be using freqstr anyways, right? There's sort of a weird dividing line on offsets about whether the constructors are public or private. I'd prefer to push this to 0.14 |
That's fine to push it off. Although I disagree about the constructors
|
Appears there hasn't been much support for changing this over time. Closing but happy to reopen if there's renewed interest |
I think this would be nice to fix. I find this API very confusing: In [133]: dtype = pd.PeriodDtype(freq=pd.offsets.QuarterEnd(startingMonth=3))
...: pd.Series([
...: "1Q2024",
...: "2Q2024",
...: "3Q2024",
...: "4Q2024",
...: ], dtype=dtype).dt.start_time
Out[133]:
0 2023-04-01
1 2023-07-01
2 2023-10-01
3 2024-01-01
dtype: datetime64[ns] |
startingMonth
is the month the quarter ends. This is confusing.The text was updated successfully, but these errors were encountered: