Skip to content

Parameter Name of startingMonth for QuarterEnd is Misleading #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cancan101 opened this issue Oct 24, 2013 · 4 comments
Open

Parameter Name of startingMonth for QuarterEnd is Misleading #5307

cancan101 opened this issue Oct 24, 2013 · 4 comments
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets

Comments

@cancan101
Copy link
Contributor

startingMonth is the month the quarter ends. This is confusing.

@jtratner
Copy link
Contributor

I don't think this is worth changing - should be using freqstr anyways, right? There's sort of a weird dividing line on offsets about whether the constructors are public or private. I'd prefer to push this to 0.14

@cancan101
Copy link
Contributor Author

That's fine to push it off. Although I disagree about the constructors
being quasi private.
On Oct 23, 2013 9:49 PM, "Jeff Tratner" [email protected] wrote:

I don't think this is worth changing - should be using freqstr anyways,
right? There's sort of a weird dividing line on offsets about whether the
constructors are public or private. I'd prefer to push this to 0.14


Reply to this email directly or view it on GitHubhttps://github.com//issues/5307#issuecomment-26961104
.

@mroeschke
Copy link
Member

Appears there hasn't been much support for changing this over time. Closing but happy to reopen if there's renewed interest

@WillAyd WillAyd reopened this Apr 18, 2024
@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2024

I think this would be nice to fix. I find this API very confusing:

In [133]:   dtype = pd.PeriodDtype(freq=pd.offsets.QuarterEnd(startingMonth=3))
     ...:   pd.Series([
     ...:       "1Q2024",
     ...:       "2Q2024",
     ...:       "3Q2024",
     ...:       "4Q2024",
     ...:   ], dtype=dtype).dt.start_time
Out[133]: 
0   2023-04-01
1   2023-07-01
2   2023-10-01
3   2024-01-01
dtype: datetime64[ns]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets
Projects
None yet
Development

No branches or pull requests

5 participants