BUG: to_dense now preserves dtype in SparseArray #10655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes values and get_values. closes pandas-dev#10648
| @@ -266,7 +266,8 @@ def to_dense(self, fill=None): | |||
| # fill the nans | |||
| if fill is None: | |||
| fill = self.fill_value | |||
| if not np.isnan(fill): | |||
| # nans can only occur arrays of floating scalars | |||
| if np.issubdtype(self.dtype, np.inexact) and not np.isnan(fill): | |||
There was a problem hiding this comment.
a better way to do this is just use isnull which handles all of these things.
jreback
added
Bug
Dtype Conversions
|
@jreback sorry for being slow in getting back to this, I'll make the changes requested before the week is out. |
|
can you update |
|
@ebolyen can you update according to comments. need a whatsnew note as well. |
| assert_almost_equal(self.arr.values, self.arr_data) | ||
| assert_almost_equal(self.arr.to_dense(), self.arr_data) | ||
| assert_almost_equal(self.arr.sp_values, np.asarray(self.arr)) | ||
| for arr, arr_data in ((self.arr, self.arr_data), |
There was a problem hiding this comment.
include the issue number as a comment here
|
can you update according to comments |
|
closing, but pls reopen if you'd like to work on this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes values and get_values.
fixes #10648