CLN: removes BinGrouper kind of cython methods #10976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
prob the most lines removed at one time! can you do an asv run and see if any anomalies. you can kill that bin grouper test (that you are now skipping) as well. |
|
I checked with vbench and benchmarks were stable. this line is the only added overhead which is pretty efficient |
jreback
added a commit
that referenced
this pull request
Sep 3, 2015
CLN: removes BinGrouper kind of cython methods
|
gr8 thanks! |
|
Very nice! I was wondering why we had all these binned groupby routines in Cython. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.