Skip to content

DOC: Comparison with SAS #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2015
Merged

DOC: Comparison with SAS #11087

merged 1 commit into from
Sep 13, 2015

Conversation

chris-b1
Copy link
Contributor

closes #11075
xref #4052

There doesn't seem to be a straightforward way to syntax highlight the SAS code, so it will format as generic code blocks.

@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

lots of lexers here: http://pygments.org/docs/lexers/#lexers-for-the-r-s-languages

isn't it actual S syntax?

@chris-b1
Copy link
Contributor Author

No, SAS has its own syntax.

@jreback jreback added the Docs label Sep 13, 2015
@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

can you render and post this page

@jreback jreback added this to the 0.17.0 milestone Sep 13, 2015
@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

can also add to the highlites section in v0.17.0 (and add to the release.rst the same line).

@chris-b1
Copy link
Contributor Author

Here's the rendered output - for some reason in-line code segments don't get rendered correctly locally for me (on all doc pages).
docs

@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

@chris-b1 looks pretty good.

I need a more full look, but @jorisvandenbossche ?


.. code-block:: python

tips = pd.read_csv('tips.csv', delim='\t', header=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delim -> sep (delimiter is a valid keyword alternative to sep, but sep is the preferred one (listed first in the docstring))

@jorisvandenbossche
Copy link
Member

@chris-b1 Really cool!!

just added some minor comments

@chris-b1
Copy link
Contributor Author

@jorisvandenbossche - pushed changes for your comments, thanks for taking a look. Rendered output above is also updated.

such as Excel, HDF5, and SQL databases. These are all read via a ``pd.read_*``
function. See the :ref:`IO documentation<io>` for more details.

Exporting data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use : for sub-headings / headings...

@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

@chris-b1 just a couple of minor edits / suggestions.

really nice!

ping when ready for merge.

@chris-b1
Copy link
Contributor Author

Thanks! @jreback pushed changes for your notes, should be good to merge.

jreback added a commit that referenced this pull request Sep 13, 2015
@jreback jreback merged commit fea7f6c into pandas-dev:master Sep 13, 2015
@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

awesome. pls have a look once they are built and do a follow-up if needed!

@chris-b1 chris-b1 deleted the sas-docs branch September 13, 2015 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Comparison with SAS
3 participants