-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: PeriodIndex now accepts pd.NaT #13430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 84.25%@@ master #13430 diff @@
==========================================
Files 138 138
Lines 50810 50805 -5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42809 42805 -4
+ Misses 8001 8000 -1
Partials 0 0
|
raise IncompatibleFrequency(msg) | ||
|
||
if p is tslib.NaT: | ||
ordinals[i] = tslib.iNaT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these only integers at this point? e.g. we normally use a very generic check for NaT, is_null_datetimelike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this is possible to be called with both int64 and object types so for sure need to check all cases here
lgtm. ping on green. |
ty sir! |
git diff upstream/master | flake8 --diff
Related to #12759.
PeirodIndex
can be created from list/array which containspd.NaT
.currently it raises: