BUG: allow describe() for DataFrames with only boolean columns #13898
Conversation
|
Thx for the PR! We appreciate including the tests from first to see the detail. |
sinhrks
added
Bug
Numeric Operations
| @@ -5138,9 +5139,11 @@ def describe_1d(data): | |||
| if self.ndim == 1: | |||
| return describe_1d(self) | |||
| elif (include is None) and (exclude is None): | |||
| if len(self._get_numeric_data()._info_axis) > 0: | |||
| if len(self._get_numeric_data(exclude_bool=True)._info_axis) > 0: | |||
| # when some numerics are found, keep only numerics | |||
| data = self.select_dtypes(include=[np.number]) | |||
There was a problem hiding this comment.
is there any reason to change _get_numeric_data rather than changing this line?
There was a problem hiding this comment.
Updated PR with a more minimal approach.
Current coverage is 85.30% (diff: 100%)@@ master #13898 diff @@
==========================================
Files 139 139
Lines 50143 50143
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42777 42776 -1
- Misses 7366 7367 +1
Partials 0 0
|
| if len(self._get_numeric_data()._info_axis) > 0: | ||
| ncols_numeric = len(self._get_numeric_data()._info_axis) | ||
| ncols_bool = len(self._get_bool_data()._info_axis) | ||
| if ncols_numeric > ncols_bool: |
There was a problem hiding this comment.
it doesn't look correct. we want bool describe only when there is no number column?
There was a problem hiding this comment.
But it is correct! BoolBlock inherits from NumericBlock, so ncols_numeric is always greater than or equal to ncols_bool. If they differ, we do have non-boolean numeric columns, which we select with np.number. If they coincide and ncols_bool > 0, the only numeric columns are boolean and we get them with np.bool. The remaining case has no numeric columns — not even boolean.
There was a problem hiding this comment.
Thus u don't have to change the line, when self.select_dtypes(include=[np.number]) is empty use self.
There was a problem hiding this comment.
I agree use .select_dtype here
There was a problem hiding this comment.
Ah, now I understand. Indeed, much cleaner.
|
@sinhrks Changes made. |
|
lgtm. ping on green. |
? |
|
when all of the checks have passed it will turn grin. ping then. |
|
thanks @agraboso |
git diff upstream/master | flake8 --diffCloses #13891. Existing tests pass.
No new tests added yet.