Skip to content

DOC: fix pd.to_datetime documentation (issue #14448) #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tarun16feb
Copy link

@tarun16feb tarun16feb commented Oct 19, 2016

Dupe of #14452

@tarun16feb tarun16feb changed the title DOC: fix documentation (issue #14448) DOC: fix pd.to_datetime documentation (issue #14448) Oct 19, 2016
@codecov-io
Copy link

Current coverage is 85.25% (diff: 100%)

Merging #14456 into master will increase coverage by <.01%

@@             master     #14456   diff @@
==========================================
  Files           140        140          
  Lines         50631      50631          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43166      43167     +1   
+ Misses         7465       7464     -1   
  Partials          0          0          

Powered by Codecov. Last update c31ea34...5890a0d

@@ -267,7 +267,7 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False,
If a date that does not meet timestamp limitations, passing errors='coerce'
will force to NaT. Furthermore this will force non-dates to NaT as well.

>>> pd.to_datetime('13000101', format='%Y%m%d')
Copy link
Member

@sinhrks sinhrks Oct 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice to add an example of default behavior, and describe what the timestamp limitation is,

@sinhrks sinhrks added Docs Datetime Datetime data dtype labels Oct 20, 2016
@sinhrks sinhrks added this to the 0.19.1 milestone Oct 20, 2016
@sinhrks
Copy link
Member

sinhrks commented Oct 20, 2016

Ah, it's dupe with #14452. Appreciate your review on #14452.

@sinhrks sinhrks closed this Oct 20, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: No action, 0.19.1 Oct 20, 2016
@jorisvandenbossche jorisvandenbossche added the Duplicate Report Duplicate issue or pull request label Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Docs Duplicate Report Duplicate issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC/BUG: pd.to_datetime example produces different results from documentation
4 participants