CLN: Resubmit of GH14700. Fixes GH14554. Errors other than Indexing… #14912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror and KeyError now bubble up appropriately.
Current coverage is 84.57% (diff: 0.00%)@@ master #14912 diff @@
==========================================
Files 144 144
Lines 51057 51057
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43180 43180
Misses 7877 7877
Partials 0 0
|
sinhrks
added
Bug
Error Reporting
|
so this is segfaulting (with the OP issue) on py3. any thoughts on this |
|
thanks! note as per my comment above, this (and master and 0.19.1) segfault in python 3. not sure what if anything can do about that (they segfault because of the recursion). any ideas? |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 24, 2016
IdnexError and KeyError now bubble up appropriately. closes pandas-dev#14554 Author: Chris Ham <[email protected]> Closes pandas-dev#14912 from clham/gh14554-b and squashes the following commits: 458c0cc [Chris Ham] CLN: Resubmit of GH14700. Fixes GH14554. Errors other than IndexingError and KeyError now bubble up appropriately. (cherry picked from commit 3ccb501)
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
IdnexError and KeyError now bubble up appropriately. closes pandas-dev#14554 Author: Chris Ham <[email protected]> Closes pandas-dev#14912 from clham/gh14554-b and squashes the following commits: 458c0cc [Chris Ham] CLN: Resubmit of GH14700. Fixes GH14554. Errors other than IndexingError and KeyError now bubble up appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Error and KeyError now bubble up appropriately.
git diff upstream/master | flake8 --diff