TST: Concat MultiIndex dataframes with deepcopy (#9967) #14936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 21, 2016
| ['b', 'c']], | ||
| labels=[[0, 1], [0, 0], [0, 1]], | ||
| names=['testname', None, None]) | ||
| expected = pd.DataFrame(np.array([[0], [1]]), index=expected_index) |
There was a problem hiding this comment.
on windows, np.array([[0], [1]]) is int32, so pass a dtype='int64' here on the expected, or
just use [[0], [1]] which always returns int64
======================================================================
FAIL: test_concat_multiindex_dfs_with_deepcopy (pandas.tools.tests.test_concat.TestConcatenate)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Python27_64\envs\pandas\lib\site-packages\pandas\tools\tests\test_concat.py", line 2171, in test_concat_multiindex_dfs_with_deepcopy
tm.assert_frame_equal(result, expected)
File "C:\Python27_64\envs\pandas\lib\site-packages\pandas\util\testing.py", line 1313, in assert_frame_equal
obj='DataFrame.iloc[:, {0}]'.format(i))
File "C:\Python27_64\envs\pandas\lib\site-packages\pandas\util\testing.py", line 1154, in assert_series_equal
assert_attr_equal('dtype', left, right)
File "C:\Python27_64\envs\pandas\lib\site-packages\pandas\util\testing.py", line 878, in assert_attr_equal
left_attr, right_attr)
File "C:\Python27_64\envs\pandas\lib\site-packages\pandas\util\testing.py", line 1018, in raise_assert_detail
raise AssertionError(msg)
AssertionError: Attributes are different
Attribute "dtype" are different
[left]: int64
[right]: int32
----------------------------------------------------------------------
jreback
reviewed
Dec 21, 2016
| example_dataframe2 = pd.DataFrame([1], index=example_multiindex2) | ||
|
|
||
| example_dict = {'s1': example_dataframe1, 's2': example_dataframe2} | ||
| result = pd.concat(deepcopy(example_dict), names=['testname']) |
There was a problem hiding this comment.
also do this w/o the deepcopy
|
yeah not really sure when this was fixed, if you really want, you can |
Add additional test + fix int32 error
Current coverage is 84.65% (diff: 100%)@@ master #14936 diff @@
==========================================
Files 144 144
Lines 51021 51021
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43188 43191 +3
+ Misses 7833 7830 -3
Partials 0 0
|
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
…ndas-dev#14936) Add additional test + fix int32 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffPotentially related to #10638? Otherwise, don't think this was fixed recently