DOC: Various doc fixes #16035
Merged
DOC: Various doc fixes #16035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/source/whatsnew/v0.20.0.txt
Outdated
| @@ -1357,9 +1357,9 @@ If indicated, a deprecation warning will be issued if you reference theses modul | |||
| "pandas._testing", "pandas.util.libtesting", "" | |||
| "pandas._window", "pandas.core.libwindow", "" | |||
|
|
|||
| - The function :func:`~pandas.api.type.union_categoricals` is now importable from ``pandas.api.types``, formerly from ``pandas.types.concat`` (:issue:`15998`) | |||
| - The function :func:`~pandas.api.type.union_categoricals` is now importable from ``pandas.api.types``, formerly from ```pandas.types.concat`` (:issue:`15998`) | |||
There was a problem hiding this comment.
also pandas.api.type.union_categoricals -> pandas.api.types.union_categoricals
pandas/core/generic.py
Outdated
| will be used to determine the groups (the Series' values are first | ||
| aligned; see ``.align()`` method). If an ndarray is passed, the | ||
| values as-is determine the groups. A str or list of strs maybe be | ||
| used used to group by the columns in ``self``. |
pandas/core/generic.py
Outdated
| index. If a dict or Series is passed, the Series or dict VALUES | ||
| will be used to determine the groups (the Series' values are first | ||
| aligned; see ``.align()`` method). If an ndarray is passed, the | ||
| values as-is determine the groups. A str or list of strs maybe be |
- Fixed spacing - Fixed method reference - Fixed list line wrapping - Fixed unbalanced ticks - Fixed section-heading without colon - Changed Interval Properties -> Attributes - Changed Styler properties
TomAugspurger
force-pushed
the
doc-cleanup
branch
from
9f9d47d to
d40a3ec
Compare
|
@TomAugspurger maybe leave the changes to the html repr for a separate PR? |
|
Sorry, when I pushed I didn't realize I was experimenting on this branch.
Be previous commit removed one of the changes, but I missed `core/frame.py`
…On Tue, Apr 18, 2017 at 9:06 AM, Joris Van den Bossche < ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> maybe leave the changes
to the html repr for a separate PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16035 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIqtgO3dLzWWwoz1WbsVBGpyfF-Xoks5rxMNIgaJpZM4M_QXC>
.
|
|
Doc build passed. Remaining warnings I might have a fix for the DataFrame.index, DataFrame.columns warnings, but not before the release. I'm not really sure about the IntervalIndex.str warnings. |
|
@TomAugspurger OK to merge this one? (minus the remaining change to the html) |
Yeah, some of those warnings have been there already a very long time, so those are not very important for the release.
This should probably be done similar as DatetimeIndex.str, will fix that |
0b67961 removed that, but if you want to double check before merging. |
Codecov Report
@@ Coverage Diff @@
## master #16035 +/- ##
==========================================
- Coverage 90.79% 90.77% -0.02%
==========================================
Files 156 156
Lines 50534 50535 +1
==========================================
- Hits 45882 45873 -9
- Misses 4652 4662 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16035 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 156 156
Lines 50534 50534
=======================================
Hits 45882 45882
Misses 4652 4652
Continue to review full report at Codecov.
|
|
thanks! How did you fix the Styler warnings in the end? As I see you reverted what you changed regarding the properties |
|
I have no idea why the first triggered an attempted import. The properties were nice for the docs, but you couldn't use them as class attributes anymore, which is convenient. |
rst .. (or numpydoc maybe in this case) :-) |
analyticalmonk
pushed a commit
to analyticalmonk/pandas
that referenced
this pull request
Apr 20, 2017
- Fixed spacing - Fixed method reference - Fixed list line wrapping - Fixed unbalanced ticks - Fixed section-heading without colon - Changed Interval Properties -> Attributes - Changed Styler properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #16033
Will probably do more as followups, so let's keep that open.