MAINT: Remove self.assert_* from testing #16076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16076 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 159 159
Lines 50791 50791
=======================================
Hits 46143 46143
Misses 4648 4648
Continue to review full report at Codecov.
|
|
thanks! you might want to actually add (and friends) to |
|
I'm getting to it actually. But there's more to do before I do 😁 |
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
* MAINT: Remove self.assert_almost_equal from testing * MAINT: Remove self.assert_index_equal from testing * MAINT: Remove self.assert_categorical_equal from testing * MAINT: Remove self.assert_numpy_array_equal from testing * MAINT: Remove self.assert_series_equal from testing * MAINT: Remove self.assert_frame_equal from testing * MAINT: Remove self.assert_produces_warning from testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
We should be using
tm.assert_*instead (they are static methods after all) and shouldn't really be invoked by the test instance.Partially addresses #15990.