-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: resolving issue 16357 - added a check to see if input is pandas.NaT #16501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a whatsnew entry in 0.20.2
the first thing to add even before code is a replicating test!. run the code and the test should fail (so you know that your test is good), then then patch should make the previously failing test pass.
if not self._has_same_tz(item): | ||
raise ValueError( | ||
'Passed item and index have different timezone') | ||
if item is not libts.NaT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should use and
instead of a nested if.
Codecov Report
@@ Coverage Diff @@
## master #16501 +/- ##
==========================================
+ Coverage 90.43% 90.43% +<.01%
==========================================
Files 161 161
Lines 51045 51046 +1
==========================================
+ Hits 46161 46162 +1
Misses 4884 4884
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16501 +/- ##
==========================================
+ Coverage 91% 91% +<.01%
==========================================
Files 161 161
Lines 49308 49309 +1
==========================================
+ Hits 44871 44875 +4
+ Misses 4437 4434 -3
Continue to review full report at Codecov.
|
can you rebase and update? couple of comments. |
can you u rebase and update & change release note to 0.21.0 |
can you rebase / update according to comments |
can you add the test from the issue & rebase |
closing as stale. if you want to finish up. pls ping and we can reopen. |
git diff upstream/master --name-only -- '*.py' | flake8 --diff