Skip to content

BUG: resolving issue 16357 - added a check to see if input is pandas.NaT #16501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

theodoreschen
Copy link

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a whatsnew entry in 0.20.2

the first thing to add even before code is a replicating test!. run the code and the test should fail (so you know that your test is good), then then patch should make the previously failing test pass.

if not self._has_same_tz(item):
raise ValueError(
'Passed item and index have different timezone')
if item is not libts.NaT:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use and instead of a nested if.

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Datetime Datetime data dtype labels May 25, 2017
@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #16501 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16501      +/-   ##
==========================================
+ Coverage   90.43%   90.43%   +<.01%     
==========================================
  Files         161      161              
  Lines       51045    51046       +1     
==========================================
+ Hits        46161    46162       +1     
  Misses       4884     4884
Flag Coverage Δ
#multiple 88.27% <100%> (ø) ⬆️
#single 40.16% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 95.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81f3cc...7fb8395. Read the comment docs.

@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #16501 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16501      +/-   ##
==========================================
+ Coverage      91%      91%   +<.01%     
==========================================
  Files         161      161              
  Lines       49308    49309       +1     
==========================================
+ Hits        44871    44875       +4     
+ Misses       4437     4434       -3
Flag Coverage Δ
#multiple 88.78% <100%> (+0.02%) ⬆️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 95.33% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9d6d3...16a1e43. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 10, 2017

can you rebase and update?

couple of comments.

@jreback
Copy link
Contributor

jreback commented Jul 7, 2017

can you u rebase and update & change release note to 0.21.0

@jreback
Copy link
Contributor

jreback commented Jul 19, 2017

can you rebase / update according to comments

@jreback
Copy link
Contributor

jreback commented Sep 10, 2017

can you add the test from the issue & rebase

@jreback
Copy link
Contributor

jreback commented Oct 14, 2017

closing as stale. if you want to finish up. pls ping and we can reopen.

@jreback jreback closed this Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: insert NaT into tz-aware DTI.
2 participants