BUG: resample with non-existant columns #16973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Add tests. |
|
needs tests from the issue. |
jreback
changed the title
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffI have added a check for keys in
Resampler._gotitem. I am not sure if it's the best place to put this check.df.groupby('x').agg({'z': ['sum'] })works as pointed out by @chris-b1 but I suspect there is no explicit check if the key exists or not. From what I found the code errors insideDataFrameGroupBy._gotitem, due to theself.obj[key]call which is not inResampler._gotitem. If this is a suitable fix, I can add similar check inDataFrameGroupBy._gotitem(current traceback is very messy).