CLN: ASV index_object benchmark #18758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 24, 2017 at 06:27 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #18758 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.03%
==========================================
Files 150 150
Lines 48959 48959
==========================================
- Hits 44843 44833 -10
- Misses 4116 4126 +10
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 13, 2017
asv_bench/benchmarks/index_object.py
Outdated
| self.idx_rng2 = self.idx_rng[:(-1)] | ||
| fmt = '%Y-%m-%d %H:%M:%S' | ||
| self.date_str_left = Index(self.dates_left.strftime(fmt)) | ||
| self.date_str_right = self.date_str_left[:-1] |
There was a problem hiding this comment.
you could parametrize these over the actual operations (e.g. difference, intersection, etc). if you think its worth it.
There was a problem hiding this comment.
There is one black sheep benchmark, time_datetime_difference_disjoint, that makes it a little more work to parametrize, but if i separate it out to a new class the rest should be easy to parametrize
|
Parametrized the |
asv_bench/benchmarks/indexing.py
Outdated
| @@ -369,3 +369,47 @@ def time_assign_with_setitem(self): | |||
| self.df[i] = np.random.randn(self.N) | |||
|
|
|||
|
|
|||
| class Float64(object): | |||
There was a problem hiding this comment.
I would personally keep those in the index benchmarks, as indexing an index is something completely different (implementation wise) than indexing a series/dataframe
|
@jorisvandenbossche consolidated those index indexing benchmarks back to |
|
can you rebase |
mroeschke
force-pushed
the
asv_clean_index_object
branch
from
9da1480 to
add0d71
Compare
|
rebased and all green. |
|
Thanks! |
hexgnu
pushed a commit
to hexgnu/pandas
that referenced
this pull request
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove star imports and flake8 checked
Moved some index constructor benchmarks to
ctors.py(probably should rename this file in the future)Moved some index indexing benchmarks to
indexing.py