Skip to content

CLN: ASV reindex #18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2017
Merged

CLN: ASV reindex #18938

merged 2 commits into from
Dec 26, 2017

Conversation

mroeschke
Copy link
Member

Flake8'd, utilized params and simplified setup where possible.

$ asv dev -b ^reindex
· Discovering benchmarks
· Running 17 total benchmarks (1 commits * 1 environments * 17 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  5.88%] ··· Running ...ex.Align.time_align_series_irregular_string      604ms
[ 11.76%] ··· Running reindex.DropDuplicates.time_frame_drop_dups            ok
[ 11.76%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    26.9ms 
                 False    24.8ms 
               ========= ========

[ 17.65%] ··· Running ...ex.DropDuplicates.time_frame_drop_dups_bool         ok
[ 17.65%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    6.48ms 
                 False    7.86ms 
               ========= ========

[ 23.53%] ··· Running ...dex.DropDuplicates.time_frame_drop_dups_int         ok
[ 23.53%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    73.2ms 
                 False    65.5ms 
               ========= ========

[ 29.41%] ··· Running reindex.DropDuplicates.time_frame_drop_dups_na         ok
[ 29.41%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    30.3ms 
                 False    29.5ms 
               ========= ========

[ 35.29%] ··· Running ...ex.DropDuplicates.time_series_drop_dups_int         ok
[ 35.29%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    1.41ms 
                 False    1.35ms 
               ========= ========

[ 41.18%] ··· Running ...DropDuplicates.time_series_drop_dups_string         ok
[ 41.18%] ···· 
               ========= ========
                inplace          
               --------- --------
                  True    1.81ms 
                 False    1.78ms 
               ========= ========

[ 47.06%] ··· Running reindex.Fillna.time_float_32                           ok
[ 47.06%] ···· 
               ========== =======
                 method          
               ---------- -------
                  pad      816μs 
                backfill   911μs 
               ========== =======

[ 52.94%] ··· Running reindex.Fillna.time_reindexed                          ok
[ 52.94%] ···· 
               ========== ========
                 method           
               ---------- --------
                  pad      1.68ms 
                backfill   1.45ms 
               ========== ========

[ 58.82%] ··· Running reindex.LevelAlign.time_align_level                29.5ms
[ 64.71%] ··· Running reindex.LevelAlign.time_reindex_level              31.3ms
[ 70.59%] ··· Running reindex.LibFastZip.time_lib_fast_zip               30.2ms
[ 76.47%] ··· Running reindex.LibFastZip.time_lib_fast_zip_fillna        35.4ms
[ 82.35%] ··· Running reindex.Reindex.time_reindex_columns               2.25ms
[ 88.24%] ··· Running reindex.Reindex.time_reindex_dates                 1.90ms
[ 94.12%] ··· Running reindex.Reindex.time_reindex_multiindex             650ms
[100.00%] ··· Running reindex.ReindexMethod.time_reindex_method              ok
[100.00%] ···· 
               ========== ========
                 method           
               ---------- --------
                  pad      7.01ms 
                backfill   6.87ms 
               ========== ========

@sinhrks sinhrks added Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance labels Dec 25, 2017
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #18938 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18938      +/-   ##
==========================================
+ Coverage   91.59%   91.59%   +<.01%     
==========================================
  Files         150      150              
  Lines       48959    48959              
==========================================
+ Hits        44843    44845       +2     
+ Misses       4116     4114       -2
Flag Coverage Δ
#multiple 89.96% <ø> (ø) ⬆️
#single 41.13% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 84.9% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdebcf3...214b7e3. Read the comment docs.

@jreback jreback added this to the 0.23.0 milestone Dec 26, 2017
@jreback jreback merged commit 95e79a7 into pandas-dev:master Dec 26, 2017
@jreback
Copy link
Contributor

jreback commented Dec 26, 2017

thanks, fillMethod was long ago deprecated :<

hexgnu pushed a commit to hexgnu/pandas that referenced this pull request Dec 28, 2017
@mroeschke mroeschke deleted the asv_clean_reindex branch December 31, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants