implement ABCInterval #19367
Merged
implement ABCInterval #19367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
reviewed
Jan 24, 2018
pandas/core/dtypes/generic.py
Outdated
| @@ -54,6 +54,7 @@ def _check(cls, inst): | |||
| ABCPeriod = create_pandas_abc_type("ABCPeriod", "_typ", ("period", )) | |||
| ABCDateOffset = create_pandas_abc_type("ABCDateOffset", "_typ", | |||
| ("dateoffset",)) | |||
| ABCInterval = create_pandas_abc_type("ABCPeriod", "_typ", ("interval", )) | |||
There was a problem hiding this comment.
The first argument should be "ABCInterval" instead of "ABCPeriod", right? Or am I missing something?
There was a problem hiding this comment.
@jschendel : I don't believe you are.
There was a problem hiding this comment.
@jbrockmendel : Do we need any tests for this new ABCType ?
There was a problem hiding this comment.
Yah typo, will fix, good catch.
gfyoung
added
Interval
|
need test in pandas/tests/dtypes/test_generic.py |
Codecov Report
@@ Coverage Diff @@
## master #19367 +/- ##
==========================================
- Coverage 91.61% 91.6% -0.02%
==========================================
Files 150 150
Lines 48677 48685 +8
==========================================
+ Hits 44595 44596 +1
- Misses 4082 4089 +7
Continue to review full report at Codecov.
|
gfyoung
approved these changes
Jan 24, 2018
jreback
approved these changes
Jan 25, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid python-space import in lib
git diff upstream/master -u -- "*.py" | flake8 --diff