-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Use cythonize for build #19484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cythonize for build #19484
Conversation
pandas/_libs/util.pyx
Outdated
return PyObject_TypeCheck(obj, &PyTimedeltaArrType_Type) | ||
|
||
|
||
cdef inline bint is_datetime64_object(object obj) nogil: | ||
cdef bint is_datetime64_object(object obj) nogil: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think these should actually be in the .pxd
Codecov Report
@@ Coverage Diff @@
## master #19484 +/- ##
==========================================
- Coverage 91.67% 91.6% -0.08%
==========================================
Files 148 150 +2
Lines 48553 48750 +197
==========================================
+ Hits 44513 44657 +144
- Misses 4040 4093 +53
Continue to review full report at Codecov.
|
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 06, 2018 at 06:47 Hours UTC |
It looks like the CI errors are occurring in builds with cython pinned to 0.24.0. The un-pinned builds are using 0.27.3 and passing. Running locally it looks like 0.25.0 still breaks, but 0.26.0 works. |
@gfyoung any idea what the timeline is for bumping the cython specs? This is going nowhere until that happens, so may be closable. |
@jbrockmendel : Not my call unfortunately. Let's ping @jreback about this. |
we changed this dep to 0.23 in pandas 0.20.1 |
It looks like implementing tslibs.util is a/the fix for the older cythons. |
looks good. going to need a perf check. might want to put the util changes in a separate PR? |
Ran the whole asv suite a few times overnight.
And the whole suite:
|
Going through looking for asv entries that show up repeatedly:
A whole mess of stopping the search here. This is more change than I'm comfortable with; I'll try to track down the source. Let's stick a pin in this for now. |
Discussed back in #18089. This builds OK locally, we'll see about the CI...
util
a module instead of a stub.