CLN: remove unused try_cast kwarg from ops #23258
Conversation
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
pandas/core/internals/blocks.py
Outdated
| @@ -1318,7 +1318,7 @@ def shift(self, periods, axis=0, mgr=None): | |||
|
|
|||
| return [self.make_block(new_values)] | |||
|
|
|||
| def eval(self, func, other, errors='raise', try_cast=False, mgr=None): | |||
| def eval(self, func, other, errors='raise', mgr=None): | |||
There was a problem hiding this comment.
Given recent implementation of ops.dispatch_to_series, we only ever get here with try_cast=False, so we can remove the kwarg altogether.
|
Travis failure is in feather |
|
this is fine (I think you have these changes in another PR as well), but happy to merge this. ping on green. |
|
Yah, this one goes a little further in getting rid of the kwarg for Panel and is generally much more focused. The other one is a bit all over the place, largely because of an accidental push of unrelated test cleanup. |
Codecov Report
@@ Coverage Diff @@
## master #23258 +/- ##
=========================================
Coverage ? 92.22%
=========================================
Files ? 169
Lines ? 50909
Branches ? 0
=========================================
Hits ? 46952
Misses ? 3957
Partials ? 0
Continue to review full report at Codecov.
|
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff