Skip to content

CLN: small clean-up PeriodIndex (easy parts of #23416) #23423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 30, 2018

xref #23416

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #23423 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23423      +/-   ##
==========================================
+ Coverage   92.19%   92.21%   +0.02%     
==========================================
  Files         161      161              
  Lines       51192    51173      -19     
==========================================
- Hits        47197    47190       -7     
+ Misses       3995     3983      -12
Flag Coverage Δ
#multiple 90.65% <100%> (+0.02%) ⬆️
#single 42.23% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 96.11% <100%> (+2.1%) ⬆️
pandas/core/indexes/period.py 92.15% <100%> (+1.11%) ⬆️
pandas/io/feather_format.py 77.14% <0%> (-8.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7191af9...1573d21. Read the comment docs.

@gfyoung gfyoung added Period Period data type Clean labels Oct 31, 2018
@jorisvandenbossche jorisvandenbossche changed the title REF: easy parts of #23416 CLN: small clean-up PeriodIndex (easy parts of #23416) Oct 31, 2018
@jorisvandenbossche jorisvandenbossche merged commit 59b275c into pandas-dev:master Oct 31, 2018
@jorisvandenbossche
Copy link
Member

Thanks!

@jbrockmendel jbrockmendel deleted the bigups branch October 31, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants