-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Bumping up min version for pyarrow #23482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping up min version for pyarrow #23482
Conversation
Hello @anjsudh! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting issues run: LINT=1 ci/code_checks.sh
locally to see.
also can you put a check on fastparquet < 0.1 (or could do 0.1.2) i think is ok too
@martindurant what is the oldest fastparquet that we should target here? |
Can you run |
Since this is for newer pandas, and fastparquet is pretty light on specific versions of its dependencies, I would keep with the most recent, 0.1.6, which is now 2.5 months old. I ought to put out a new version but wouldn't ask you to depend on it. |
@martindurant well, this version of pandas could easily be installed on an existing setup, so easier to allow an older version unless we really need to upgrade it. ok let's go with 0.1.2 then. |
0.1.2 is over a year old. OK, if the tests still pass... My point was, if someone was wanting to upgrade their pandas, it should be reasonable for them to upgrade fastparquet too. |
there is no easy way to force an upgrade as fp is just one of many optional dependencies so much easier to have backward compatibility rather than annoy users |
19358a5
to
be2eccb
Compare
Codecov Report
@@ Coverage Diff @@
## master #23482 +/- ##
==========================================
+ Coverage 92.23% 92.25% +0.02%
==========================================
Files 161 161
Lines 51197 51176 -21
==========================================
- Hits 47220 47214 -6
+ Misses 3977 3962 -15
Continue to review full report at Codecov.
|
so shall i go ahead with fastparquet 0.1.2 as minimum version? |
Ran scripts/convert_deps.py to update dependencies in ci/requirements-optional-pip.txt
have set min version for fastparquet as 0.1.2. |
you have a lint error
ping on green. |
Thanks! |
* Bumping up min version for pyarrow
* Bumping up min version for pyarrow
* Bumping up min version for pyarrow
* Bumping up min version for pyarrow
closes #18742
closes #23409
git diff upstream/master -u -- "*.py" | flake8 --diff