BUG GH23451 Allow setting date in string index for Series #23495

JustinZhengBC · 2018-11-04T19:40:36Z

closes Can't put date in Series if index is a string longer than 1 character #23451
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Prevents string indices from turning into lists of characters when setting a date.

pep8speaks · 2018-11-04T19:40:40Z

Hello @JustinZhengBC! Thanks for submitting the PR.

There are no PEP8 issues in the file pandas/core/series.py !
There are no PEP8 issues in the file pandas/tests/series/test_datetime_values.py !

jreback

needs a whatsnew note as well

jreback · 2018-11-04T20:23:01Z

pandas/core/series.py

@@ -947,6 +947,9 @@ def _set_with(self, key, value):
                except Exception:
                    pass

+            if isinstance(key, str):
+                key = [key]
+
            if not isinstance(key, (list, Series, np.ndarray, Series)):


Series is here twice :< can you remove

this can be an elseif

jreback · 2018-11-04T20:27:15Z

pandas/core/series.py

@@ -947,6 +947,9 @@ def _set_with(self, key, value):
                except Exception:
                    pass

+            if isinstance(key, str):


you might be able to make this is_scalar

jreback · 2018-11-04T20:27:39Z

pandas/tests/series/test_datetime_values.py

@@ -548,3 +548,9 @@ def test_minmax_nat_series(self, nat):
    def test_minmax_nat_dataframe(self, nat):
        assert nat.min()[0] is pd.NaT
        assert nat.max()[0] is pd.NaT
+
+    def test_set_dt_with_string_index(self):
+        from datetime import date


imports go at the top

jreback · 2018-11-04T20:28:25Z

pandas/tests/series/test_datetime_values.py

+    def test_set_dt_with_string_index(self):
+        from datetime import date
+        x = pd.Series([1, 2, 3], index=['Date', 'b', 'other'])
+        x.Date = date.today()


can you try this both as (parametrize)
x.Date = and x['Date'] =

I can't seem to figure out how to parametrize both these cases, as "Date" is being used in different contexts. What would be the variable(s) I parametrize and how would I use it with x to cover both cases?

codecov · 2018-11-04T20:43:55Z

Codecov Report

Merging #23495 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #23495      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files         161      161              
  Lines       51176    51178       +2     
==========================================
  Hits        47214    47214              
- Misses       3962     3964       +2

Flag	Coverage Δ
#multiple	`90.63% <100%> (-0.01%)`	⬇️
#single	`42.28% <0%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/series.py	`93.7% <100%> (-0.18%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54982c2...12d2f8a. Read the comment docs.

mroeschke · 2018-11-04T20:52:33Z

Can you see if this fixes #12862 as well?

JustinZhengBC · 2018-11-04T21:10:44Z

@mroeschke it fixes the issue of strings being split into lists, but that bug still persists because for tz-aware timestamps, the data is stored in a DateTimeIndex, whereas almost every other data format is stored in an ndarray, and setting an item directly requires an ndarray to be passed to the backend function. After this, I can do a quick PR to make the [] operator work just like using .loc, but it would still lose the timezone data after adding a new item. @jreback is that okay or should the problem be fixed closer to the root cause?

jreback

small comments, ping on green.

jreback · 2018-11-05T19:20:16Z

doc/source/whatsnew/v0.24.0.txt

@@ -1115,6 +1115,7 @@ Datetimelike
 - Bug in :func:`DataFrame.combine` with datetimelike values raising a TypeError (:issue:`23079`)
 - Bug in :func:`date_range` with frequency of ``Day`` or higher where dates sufficiently far in the future could wrap around to the past instead of raising ``OutOfBoundsDatetime`` (:issue:`14187`)
 - Bug in :class:`PeriodIndex` with attribute ``freq.n`` greater than 1 where adding a :class:`DateOffset` object would return incorrect results (:issue:`23215`)
+- Bug in :class:`Series` that interpreted string indices as lists of characters when setting datetimelike values


can you add the issue number

jreback · 2018-11-05T19:21:12Z

pandas/tests/series/test_datetime_values.py

@@ -548,3 +548,10 @@ def test_minmax_nat_series(self, nat):
    def test_minmax_nat_dataframe(self, nat):
        assert nat.min()[0] is pd.NaT
        assert nat.max()[0] is pd.NaT
+
+    def test_set_dt_with_string_index(self):


rename to test_setitem_with_string_index

…G-23451

jreback · 2018-11-06T02:12:29Z

lgtm. ping on green.

JustinZhengBC · 2018-11-06T06:01:22Z

@jreback green now

jreback · 2018-11-06T13:08:49Z

thanks!

…#23495)

BUG-23451 Allow setting date in string index for Series

9d03b80

jreback requested changes Nov 4, 2018

View reviewed changes

jreback added Datetime Datetime data dtype Indexing Related to indexing on series/frames, not to indexes themselves labels Nov 4, 2018

BUG-23451 Add whatsnew and other requested changes

ad7c8ef

jreback requested changes Nov 5, 2018

View reviewed changes

jreback added this to the 0.24.0 milestone Nov 5, 2018

JustinZhengBC force-pushed the BUG-23451 branch from 9b45d24 to ec3e684 Compare November 6, 2018 00:41

BUG-23451 Make requested changes

70a0725

JustinZhengBC force-pushed the BUG-23451 branch from ec3e684 to 70a0725 Compare November 6, 2018 01:00

Merge branch 'master' of https://github.com/pandas-dev/pandas into BU…

12d2f8a

…G-23451

jreback approved these changes Nov 6, 2018

View reviewed changes

jreback merged commit c95bfd1 into pandas-dev:master Nov 6, 2018

JustinZhengBC added a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018

BUG GH23451 Allow setting date in string index for Series (pandas-dev…

013315a

…#23495)

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018

BUG GH23451 Allow setting date in string index for Series (pandas-dev…

f45b7ad

…#23495)

JustinZhengBC mentioned this pull request Nov 27, 2018

assign None to Series got ValueError #20592

Closed

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

BUG GH23451 Allow setting date in string index for Series (pandas-dev…

191adee

…#23495)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

BUG GH23451 Allow setting date in string index for Series (pandas-dev…

6dbfd42

…#23495)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG GH23451 Allow setting date in string index for Series #23495

BUG GH23451 Allow setting date in string index for Series #23495

JustinZhengBC commented Nov 4, 2018

pep8speaks commented Nov 4, 2018

jreback left a comment

jreback Nov 4, 2018

jreback Nov 4, 2018

jreback Nov 4, 2018

jreback Nov 4, 2018

jreback Nov 4, 2018

JustinZhengBC Nov 4, 2018

codecov bot commented Nov 4, 2018 •

edited

Loading

mroeschke commented Nov 4, 2018

JustinZhengBC commented Nov 4, 2018

jreback left a comment

jreback Nov 5, 2018

jreback Nov 5, 2018

jreback commented Nov 6, 2018

JustinZhengBC commented Nov 6, 2018

jreback commented Nov 6, 2018

BUG GH23451 Allow setting date in string index for Series #23495

BUG GH23451 Allow setting date in string index for Series #23495

Conversation

JustinZhengBC commented Nov 4, 2018

pep8speaks commented Nov 4, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 4, 2018 • edited Loading

Codecov Report

mroeschke commented Nov 4, 2018

JustinZhengBC commented Nov 4, 2018

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Nov 6, 2018

JustinZhengBC commented Nov 6, 2018

jreback commented Nov 6, 2018

codecov bot commented Nov 4, 2018 •

edited

Loading