-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Public API for extension arrays / types. #23532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
**API Changes** Adds * pandas.integer_array * pandas.period_array * pandas.IntervalArray * pandas.CategoricalDtype * pandas.api.extensions.IntergerArray * pandas.api.extensions.PeriodDtype * pandas.api.extensions.PeriodArray * pandas.api.extensions.IntervalDtype * pandas.api.extensions.DatetimeTZDtype And adds documentation for those.
Hello @TomAugspurger! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23532 +/- ##
==========================================
+ Coverage 92.25% 92.25% +<.01%
==========================================
Files 161 161
Lines 51186 51189 +3
==========================================
+ Hits 47222 47225 +3
Misses 3964 3964
Continue to review full report at Codecov.
|
===================================== ============================== | ||
:class:`Categorical` :ref:`categorical` | ||
:class:`DatetimeArray` TODO | ||
:class:`api.extensions.IntegerArray` :ref:`integer_na` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be consistent here, moving IntegerArray & PeriodArray into pd namespace
import pandas as pd | ||
|
||
.. _integer_na: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really sure we need a whole section for this. Feels a bit odd actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also put it in missing_data.rst
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure
This is being superseded by #23581. |
API Changes
Adds
And adds documentation for those.
The organizing principle here is "what's useful to users."
integer_array
is useful to users, so it's in the top-level, whileIntegerArray
isn't so useful on it's own, so it's inapi.extensions
.IntervalArray
is useful, so it's at the top-level.Closes #22860