Skip to content

BUG/TST: PeriodArray.__setitem__ with slice and list-like value #23991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 14 commits into from
Dec 2, 2018
Merged

BUG/TST: PeriodArray.__setitem__ with slice and list-like value #23991

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4385128
pytest for slice type in setitem
charlesdong1991 Nov 29, 2018
aacb769
remove wrong pytests
charlesdong1991 Nov 29, 2018
e19c381
new pytest in TestSetitem
charlesdong1991 Nov 29, 2018
b12f0bc
fix pytest error
charlesdong1991 Nov 29, 2018
6ca1f1a
remove a blank line to see if error disappear
charlesdong1991 Nov 29, 2018
f3db6c1
resort imports
charlesdong1991 Nov 29, 2018
fe74ea1
fix linting failure
charlesdong1991 Nov 30, 2018
0e19fdb
fix linting error
charlesdong1991 Nov 30, 2018
3e76a61
resort imports
charlesdong1991 Nov 30, 2018
ec8f68e
resort imports using isort
charlesdong1991 Nov 30, 2018
217146f
remove redundant blank line
charlesdong1991 Nov 30, 2018
74ea7b8
move to basesetitem
charlesdong1991 Dec 1, 2018
39a4807
remove unused package from import
charlesdong1991 Dec 2, 2018
6c9702e
add whatsnew description
charlesdong1991 Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pandas/tests/arrays/test_period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,21 @@ def test_sub_period():
other = pd.Period("2000", freq="M")
with pytest.raises(IncompatibleFrequency, match="freq"):
arr - other


@pytest.mark.parametrize('data', [
period_array(['2001', '2002', '2003', '2004', '2005'], freq="D")
])
def test_setitem_slice_mismatch_length_raises(data):
arr = data[:5]
with pytest.raises(ValueError):
arr[:1] = arr[:2]


@pytest.mark.parametrize('data', [
period_array(['2001', '2002', '2003', '2004', '2005'], freq="D")
])
def test_setitem_slice_array(data):
arr = data[:5].copy()
arr[:5] = data[-5:]
tm.assert_extension_array_equal(arr, data[-5:])