Skip to content

See also description formatting #24561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dylanchase
Copy link
Contributor

@dylanchase dylanchase commented Jan 2, 2019

@WillAyd WillAyd added the Docs label Jan 2, 2019
@WillAyd
Copy link
Member

WillAyd commented Jan 2, 2019

Looks pretty straightforward please ping on green

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24561 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24561      +/-   ##
==========================================
+ Coverage   92.33%   92.33%   +<.01%     
==========================================
  Files         166      166              
  Lines       52465    52465              
==========================================
+ Hits        48442    48443       +1     
+ Misses       4023     4022       -1
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/strings.py 98.58% <ø> (ø) ⬆️
pandas/util/testing.py 87.68% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf985a...f26a56a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24561 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24561      +/-   ##
==========================================
+ Coverage   92.33%   92.33%   +<.01%     
==========================================
  Files         166      166              
  Lines       52465    52465              
==========================================
+ Hits        48442    48443       +1     
+ Misses       4023     4022       -1
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/strings.py 98.58% <ø> (ø) ⬆️
pandas/util/testing.py 87.68% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf985a...f26a56a. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

is this on an exclusion list in master? @datapythonista

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a exclude list for those, so far we keep fixing, and when there are no more errors we'll add SA02 and SA03 to the docstring validation of the CI. Personally I think this is better (at least for now), having an exclude list for every docstring error we have would probably be too much complexity.

@datapythonista datapythonista merged commit 9175387 into pandas-dev:master Jan 4, 2019
@datapythonista
Copy link
Member

thanks @dylanchase

@dylanchase dylanchase deleted the see_also_description_formatting branch January 4, 2019 01:20
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants