-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
See also description formatting #24561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See also description formatting #24561
Conversation
Looks pretty straightforward please ping on green |
Codecov Report
@@ Coverage Diff @@
## master #24561 +/- ##
==========================================
+ Coverage 92.33% 92.33% +<.01%
==========================================
Files 166 166
Lines 52465 52465
==========================================
+ Hits 48442 48443 +1
+ Misses 4023 4022 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24561 +/- ##
==========================================
+ Coverage 92.33% 92.33% +<.01%
==========================================
Files 166 166
Lines 52465 52465
==========================================
+ Hits 48442 48443 +1
+ Misses 4023 4022 -1
Continue to review full report at Codecov.
|
is this on an exclusion list in master? @datapythonista |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a exclude list for those, so far we keep fixing, and when there are no more errors we'll add SA02
and SA03
to the docstring validation of the CI. Personally I think this is better (at least for now), having an exclude list for every docstring error we have would probably be too much complexity.
thanks @dylanchase |
git diff upstream/master -u -- "*.py" | flake8 --diff