-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
POC: make core.config self-contained #25176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
138c6c2
make core.config self-contained
jbrockmendel 803d4fd
Merge branch 'master' of https://github.com/pandas-dev/pandas into up…
jbrockmendel 6f96f3e
isort fixup
jbrockmendel 983f3ef
Merge branch 'master' of https://github.com/pandas-dev/pandas into up…
jbrockmendel 022ee4f
use low-tech print
jbrockmendel 40ca990
remove unused PY3
jbrockmendel 33e4b02
Merge branch 'master' of https://github.com/pandas-dev/pandas into up…
jbrockmendel 46216b0
move date opts into config
jbrockmendel 25198d0
Merge branch 'master' of https://github.com/pandas-dev/pandas into up…
jbrockmendel 18d471f
Merge branch 'master' of https://github.com/pandas-dev/pandas into up…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you moving this? this defeats the entire purpose of config_init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal is to move
config
out ofcore
(either to another dependency-free directory in pandas or something external like @topper-123's repo) and make it explicitly "upstream" from_libs
. That way we get a much cleaner dependency structure by avoiding runtime imports inside_libs
.