Read hdf does not close store #25863
Conversation
pandas/tests/io/test_pytables.py
Outdated
| df = pd.DataFrame({'a': range(2), 'b': range(2)}) | ||
| df.to_hdf(path, 'k1') | ||
|
|
||
| pytest.raises(KeyError, pd.read_hdf, path, 'k2') |
There was a problem hiding this comment.
this is not an accepted format any longer, use the context manager
with pytest.raises(....):
...
There was a problem hiding this comment.
updated 244cab4 . But with form pytest.raises(KeyError, ...) I followed the codestyle in this test file. But now I see some STY issues, that are trying to unify to context manager style 👍
There was a problem hiding this comment.
yep this happens to be the last file - i think it’s fixed in another PR
Codecov Report
@@ Coverage Diff @@
## master #25863 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 173 173
Lines 52872 52872
=======================================
Hits 48364 48364
Misses 4508 4508
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25863 +/- ##
==========================================
- Coverage 91.81% 91.8% -0.01%
==========================================
Files 175 175
Lines 52578 52578
==========================================
- Hits 48273 48269 -4
- Misses 4305 4309 +4
Continue to review full report at Codecov.
|
Co-Authored-By: rbenes <[email protected]>
…ad_hdf_does_not_close_store
|
Thanks @rbenes ! |
git diff upstream/master -u -- "*.py" | flake8 --diff