CLN: Split test_window.py further #27348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not sure we need this (probably should have closed first issue after last PR). Any interest in parametrizing instead? |
Contributor
Author
WillAyd
added
Clean
Testing
Member
|
My mistake! Though would still take parametrization (separate PR is fine) if you are up for it |
Contributor
Author
|
@WillAyd thanks for suggestion noted that |
Member
|
If this is a pure split, then I would be in favor of merging this. |
Contributor
|
thanks @ihsansecer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19228
xref #26807
git diff upstream/master -u -- "*.py" | flake8 --diffblack pandasJust splitted code into files by classes. No changes made to code
cc @jreback